Upgrade Rails from 7.2 to 8.0 by stefannibrasil · Pull Request #6955 · rubyforgood/casa

stefannibrasil · 2026-05-20T21:23:50Z

What github issue is this PR for, if any?

What changed, and why?

Rails 8.0 was released in late 2024 and brings Solid Queue / Solid Cache / Solid Cable as defaults, Propshaft, Kamal 2, Authentication generator, and a number of framework deprecations.

Most notable changes:

It's not possible to use only and except for non-RESTful routes: c64228a
I removed comments and configs from previous upgrades, and updated config/environments with the generated files as much as possible
I couldn't find out exactly where this changed in the release notes for this Rails version but I imagine it's a good change since it shows the new 404 page instead of raising a server error: c5af932
The new defaults from config/initializers/new_framework_defaults_8_0.rb look okay to be enabled altogether but if you prefer to enable them individually, let me know.
The 406 and 422 error pages have a new generated UI:

How is this tested? (please write rspec and jest tests!) 💖💪

tested the app locally
running tests
CI is passing

Followups

Once Rails 8 is up and running, we can later update the config.load_defaults to 8.0. It should fix this deprecation warning: "DEPRECATION WARNING: to_time will always preserve the full timezone rather than offset of the receiver in Rails 8.1. To opt in to the new behavior, set config.active_support.to_time_preserves_timezone = :zone. (called from <top (required)> at /home/runner/work/casa/casa/config/environment.rb:5)"
It's possible to upgrade from Sprockets to Propshaft: https://github.com/rails/propshaft/blob/main/UPGRADING.md
upgrade Rails from 8.0 to 8.1 (should be smooth, no breaking changes)

Questions

Is it possible to test this on staging/QA first? Please try this out locally and let me know if you run into any issues.

compwron · 2026-05-20T21:24:42Z

cooollll :)

This extra require was added on the latest rails upgrade but it's not necessary anymore.

rails/rails#51464

stefannibrasil · 2026-05-20T21:54:45Z

-
-foreman start -f Procfile.dev "$@"
+#!/usr/bin/env ruby
+exec "./bin/rails", "server", *ARGV


I tested things locally and this seems fine. Could someone try it out and see if it's best to keep the previous changes?

stefannibrasil · 2026-05-20T21:56:02Z

+# If set to `:zone`, `to_time` methods will use the timezone of their receivers.
+# If set to `:offset`, `to_time` methods will use the UTC offset.
+# If `false`, `to_time` methods will convert to the local system UTC offset instead.
+#++


The new defaults look okay to be enabled altogether...

stefannibrasil · 2026-05-20T21:57:34Z

    end
  end
-  resources :reimbursements, only: %i[index change_complete_status], concerns: %i[with_datatable] do
+  resources :reimbursements, only: %i[index], concerns: %i[with_datatable] do


See rails/rails#51464

I tested the removed routes and they work as expected.

stefannibrasil · 2026-05-20T21:58:05Z

@@ -1,6 +1,4 @@
 require "rails_helper"
-# require "contact_type_group"


This was left here from the previous upgrade, but it's not necessary anymore.

stefannibrasil · 2026-05-20T21:59:02Z

-    it "raises RoutingError if no step in url" do
-      expect { patch "/case_contacts/#{case_contact.id}/form", params: {case_contact: attributes} }
-        .to raise_error(ActionController::RoutingError)
+    it "responds with 404 if no step in url" do


I couldn't find out exactly where this changed in the release notes for this Rails version but I imagine it's a good change since it shows the new 404 page instead of raising a server error.

stefannibrasil · 2026-05-20T22:20:26Z

@compwron could you test this branch locally and in staging as well? I want to make sure I am not introducing anything that I couldn't test locally. Thanks!

compwron · 2026-05-21T18:22:21Z

very cool, will do

compwron · 2026-05-23T06:56:00Z

annotate gem silently downgraded 3.2.0 → 2.6.5

annotate (3.2.0)
```
 activerecord (>= 3.2, < 8.0)
```

annotate (2.6.5)
```
 activerecord (>= 2.3.0)
```

annotate is unmaintained and pinned < 8.0, so bundler walked back ~7 years to find a Rails-8-compatible
version. That's a real regression — 2.6.5 predates many features and could produce different schema
annotations. Switch to the maintained fork annotaterb, or pin/remove it deliberately. Don't merge with
this downgrade.

stefannibrasil · 2026-05-25T15:30:40Z

Switch to the maintained fork annotaterb, or pin/remove it deliberately. Don't merge with this downgrade.

Ah, thanks for catching that! Since it's not compatible and it's a dev dependency that is not critical, I would propose removing annonate in a separate Pull Request, and create a follow up issue to migrate to annotaterb to be done after this Rails upgrade is done.

stefannibrasil · 2026-05-25T16:19:13Z

Actually, I created #6962 to replace annotate with annotaterb ahead of this upgrade. Once that is merged, I will update this PR.

stefannibrasil · 2026-05-25T16:34:41Z

Followups:

update config/application.rb: config.load_defaults 8.0
migrate Sprockets to propshaft
upgrade Rails from 8.0 to 8.1 (should be smooth, no breaking changes)

stefannibrasil · 2026-05-25T16:42:57Z

@compwron I handled annotate separately in #6962. That one can be merged first, then I will update this one. From there, if you could test locally again, and on QA/staging before merging this, that would be awesome 🙌🏼 I am happy to test in QA/staging as well, if that's an option. Thank you!!

compwron · 2026-05-26T17:31:22Z

Very cool :) #6962 is now merged!

stefannibrasil · 2026-05-26T17:57:13Z

thanks @compwron this is now ready for local/staging QA 🎉

compwron · 2026-05-27T14:03:11Z

-  gem install foreman
-fi
-
-foreman start -f Procfile.dev "$@"


We need the procfile for local and remote deployment, add this back? https://github.com/rubyforgood/casa/blob/main/Procfile

Sounds good! I reverted it back in 32121eb

compwron · 2026-05-27T14:03:48Z

+# explicit rubocop config increases performance slightly while avoiding config confusion.
+ARGV.unshift("--config", File.expand_path("../.rubocop.yml", __dir__))
+
+load Gem.bin_path("rubocop", "rubocop")


This codebase uses standardrb not rubocop

👍🏼 removed the file in 736b89f

Copilot

Pull request overview

Upgrades the CASA Rails application from Rails 7.2 to Rails 8.0, incorporating the Rails 8-generated configuration defaults and aligning routes, error pages, and tests with updated framework behavior.

Changes:

Bump Rails to ~> 8.0 and update Gemfile.lock / db/schema.rb accordingly.
Refresh Rails environment config (dev/test/prod), Puma config, and add new_framework_defaults_8_0.rb.
Update public error pages and adjust routing/tests to reflect Rails 8 exception/rendering behavior.

Reviewed changes

Copilot reviewed 16 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
spec/requests/case_contacts/form_spec.rb	Updates request spec expectation from raising to 404 response.
spec/models/contact_type_group_spec.rb	Removes explicit model require (leans on Rails autoloading).
public/icon.svg	Updates default icon SVG shape/size.
public/422.html	Replaces legacy 422 page with Rails 8 generated page.
public/406-unsupported-browser.html	Replaces legacy 406 page with Rails 8 generated page.
public/400.html	Adds Rails 8 generated 400 error page.
Gemfile.lock	Locks Rails 8.0.x and associated dependency updates.
Gemfile	Bumps Rails requirement to `~> 8.0`.
doc/DOCKER.md	Removes webpack dev server guidance.
db/schema.rb	Updates schema version to 8.0 and adjusts extension name output.
config/routes.rb	Adjusts `only`/`except` usage to comply with Rails 8 routing constraints.
config/puma.rb	Adds optional Solid Queue Puma plugin hook and refreshes comments.
config/initializers/new_framework_defaults_8_0.rb	Adds Rails 8 framework defaults initializer and enables settings.
config/initializers/filter_parameter_logging.rb	Expands filtered parameter list (e.g., email/card fields).
config/initializers/assets.rb	Removes older precompile comment block.
config/environments/test.rb	Updates test environment settings, including exception rendering behavior.
config/environments/production.rb	Refreshes production config to closer match Rails 8 generated defaults.
config/environments/development.rb	Refreshes development config to closer match Rails 8 generated defaults.
bin/setup	Adjusts command runner behavior in setup script.
bin/rubocop	Adds a rubocop binstub wrapper.
bin/dev	Changes dev launcher behavior (now only starts Rails server).

The Procfile is used for local and remote deployment

compwron

lgtm!

github-actions Bot added 🧪 Tests Tests dependencies Touches dependency files ruby Touches Ruby code labels May 20, 2026

stefannibrasil added 17 commits May 20, 2026 15:26

bundle update rails

25062ab

We don't use webpacker anymore

26c5be9

Remove unnecessary require from test file

630dcbc

This extra require was added on the latest rails upgrade but it's not necessary anymore.

fix invalid routes with only and except

c64228a

rails/rails#51464

committing all changes to compare on the browser

2926355

add application.rb changes back

e8e2c6f

bring custom error pages back

d105099

bring back needed configurations after override

6a743b0

this is needed

546cb03

enable rails 8.0 config defaults

46786dc

bring custom development and production configs

d2d4c87

remove this extra config

ac8147c

revert bin/setup script

34041c3

fewer file changes

577e4ea

even fewer file changes

6073c8a

keep this PR focused and leave a helpful comment

b820957

fix 404 spec

c5af932

stefannibrasil force-pushed the upgrade-to-rails-8.0 branch from 4d12204 to c5af932 Compare May 20, 2026 21:26

stefannibrasil added 2 commits May 20, 2026 15:28

Oops

fa5fcdb

linter

d37e734

stefannibrasil force-pushed the upgrade-to-rails-8.0 branch from 5eb704c to d37e734 Compare May 20, 2026 21:39

stefannibrasil commented May 20, 2026

View reviewed changes

stefannibrasil requested a review from elasticspoon as a code owner May 20, 2026 22:19

stefannibrasil mentioned this pull request May 25, 2026

Migrate annotate to annotaterb #6962

Merged

stefannibrasil added 2 commits May 25, 2026 10:26

Merge remote-tracking branch 'origin/main' into upgrade-to-rails-8.0

0d0f7a3

Rails 8: schema update (no functional change)

da04d0e

github-actions Bot added the db Touches database schema or migrations label May 25, 2026

Merge remote-tracking branch 'origin/main' into upgrade-to-rails-8.0

5fac7dd

compwron requested a review from Copilot May 27, 2026 14:02

Copilot started reviewing on behalf of compwron May 27, 2026 14:02 View session

compwron reviewed May 27, 2026

View reviewed changes

compwron previously approved these changes May 27, 2026

View reviewed changes

Copilot AI reviewed May 27, 2026

View reviewed changes

Comment thread config/environments/test.rb

Comment thread public/400.html

Comment thread public/406-unsupported-browser.html

Comment thread public/422.html

stefannibrasil added 2 commits May 27, 2026 10:01

Revert bin/dev changes

32121eb

The Procfile is used for local and remote deployment

We use standardrb, not rubocop

736b89f

stefannibrasil dismissed compwron’s stale review via 736b89f May 27, 2026 16:02

Trigger Build

6b1c5d9

compwron requested a review from Copilot May 27, 2026 16:51

Copilot started reviewing on behalf of compwron May 27, 2026 16:52 View session

compwron approved these changes May 27, 2026

View reviewed changes

compwron merged commit 90679bb into rubyforgood:main May 27, 2026
13 checks passed

stefannibrasil review requested due to automatic review settings May 27, 2026 17:14

		@@ -1,6 +1,4 @@
		require "rails_helper"
		# require "contact_type_group"

Uh oh!

Conversation

stefannibrasil commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What github issue is this PR for, if any?

What changed, and why?

How is this tested? (please write rspec and jest tests!) 💖💪

Followups

Questions

Uh oh!

compwron commented May 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stefannibrasil commented May 20, 2026

Uh oh!

compwron commented May 21, 2026

Uh oh!

compwron commented May 23, 2026

Uh oh!

stefannibrasil commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefannibrasil commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefannibrasil commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefannibrasil commented May 25, 2026

Uh oh!

compwron commented May 26, 2026

Uh oh!

stefannibrasil commented May 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

compwron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stefannibrasil commented May 20, 2026 •

edited

Loading

stefannibrasil commented May 25, 2026 •

edited

Loading

stefannibrasil commented May 25, 2026 •

edited

Loading

stefannibrasil commented May 25, 2026 •

edited

Loading